Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster processing of dependencies #2321

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Faster processing of dependencies #2321

merged 6 commits into from
Apr 1, 2024

Conversation

knokknok
Copy link
Contributor

In reference to #2318, would the following work?

@yihui yihui requested a review from atusy March 30, 2024 04:19
Copy link
Collaborator

@atusy atusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knokknok

Thank you for the PR.
It seems you are on the right direction.
I added some nit-picking comments about docs and formats.

R/block.R Outdated Show resolved Hide resolved
R/cache.R Outdated Show resolved Hide resolved
R/cache.R Outdated Show resolved Hide resolved
R/cache.R Outdated Show resolved Hide resolved
R/cache.R Outdated Show resolved Hide resolved
yihui and others added 4 commits April 1, 2024 10:42
[ci skip]

Co-authored-by: atusy <30277794+atusy@users.noreply.github.com>
…ctor of arbitrary labels instead of only a single label
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've revised the PR according to @atusy's feedback. Thanks!

@yihui yihui linked an issue Apr 1, 2024 that may be closed by this pull request
@yihui yihui merged commit f36e52c into yihui:master Apr 1, 2024
1 check passed
@atusy
Copy link
Collaborator

atusy commented Apr 2, 2024

My pleasure!
Looks perfect!!

@heavywatal heavywatal mentioned this pull request May 28, 2024
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Algorithmic complexity of dep_auto
3 participants