fix autodep regression by #2321 (closes #2344) #2374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
atusy
commented
Oct 17, 2024
atusy
commented
- fix autodep regression by #2321 #2344: call dep_auto() automatically
- test autodep regression by #2321 #2344: call dep_auto() automatically
- test autodep regression by #2321 #2344: additional tests on dep_auto()
atusy
commented
Oct 17, 2024
| dep_list$restore() | ||
| knit_code$restore() | ||
|
|
||
| assert('dep_auto() solves dependencies of parent and child documents', { |
There was a problem hiding this comment.
Should this test case pass?
As far as I tried, the test fails even if calling dep_auto(labels = all_labels() on every chunk.
This implies knitr has hailed to solve this kind of complex cache dependencies even before #2344.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.