Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pie chart #6

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Create pie chart #6

wants to merge 27 commits into from

Conversation

KuiMing
Copy link

@KuiMing KuiMing commented May 12, 2015

  1. Create Pie Chart. echart(x,~name, ~value,type='pie')
  2. Data removable and calculable.
  3. MagicType, restore and saveAsImage was added.

@@ -0,0 +1,43 @@
pieEx1 = list(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like a good example in my eyes. Ideally we should not require users to prepare a huge list for echart(), otherwise that defeats the purpose of this package. Instead, we want something as simple as echart(data, ~variable, type = 'pie'). Do you have a better example?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's my fault. It was just for testing on my own. I will give a simple example.

@yihui
Copy link
Owner

yihui commented May 14, 2015

Two more things:

  1. Please provide some screenshots.
  2. Eventually I will need you to clean up the commit history. If you are not very familiar with GIT, I have some instructions here: https://github.com/yihui/knitr/blob/master/CONTRIBUTING.md#pull-requests

Thanks!

1. give a real example code for pie chart.
2. give a pie.html
3. remove unnecessary code of data.R and echart.R
4. add eConfig and etoolbox in option.R
@KuiMing
Copy link
Author

KuiMing commented May 17, 2015

Improvement according to comment at 2015/5/14

  1. give a real example code for pie chart.
  2. give a pie.html
  3. remove unnecessary code of data.R and echart.R
  4. add eConfig and etoolbox in option.R

@KuiMing
Copy link
Author

KuiMing commented May 17, 2015

One more thing, I will rebase after you confirm these are ok.

@KuiMing
Copy link
Author

KuiMing commented May 24, 2015

Hello Yihui,

Did you check my new code? Is there anything I need to modify?

1. create candlestick chart
2. modify pie chart
version update
egauge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants