-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pie chart #6
base: master
Are you sure you want to change the base?
Conversation
KuiMing
commented
May 12, 2015
- Create Pie Chart. echart(x,~name, ~value,type='pie')
- Data removable and calculable.
- MagicType, restore and saveAsImage was added.
@@ -0,0 +1,43 @@ | |||
pieEx1 = list( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not look like a good example in my eyes. Ideally we should not require users to prepare a huge list for echart()
, otherwise that defeats the purpose of this package. Instead, we want something as simple as echart(data, ~variable, type = 'pie')
. Do you have a better example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it's my fault. It was just for testing on my own. I will give a simple example.
Two more things:
Thanks! |
1. give a real example code for pie chart. 2. give a pie.html 3. remove unnecessary code of data.R and echart.R 4. add eConfig and etoolbox in option.R
Improvement according to comment at 2015/5/14
|
One more thing, I will rebase after you confirm these are ok. |
Hello Yihui, Did you check my new code? Is there anything I need to modify? |
1. create candlestick chart 2. modify pie chart