fix the bug in broken_packages() reported at rstudio/rmarkdown#1990 (…

…comment)
yihui · Jun 30, 2021 · 1507dbf · 1507dbf
1 parent b3162ce
commit 1507dbf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: xfun
 Type: Package
 Title: Supporting Functions for Packages Maintained by 'Yihui Xie'
-Version: 0.24.1
+Version: 0.24.2
 Authors@R: c(
   person("Yihui", "Xie", role = c("aut", "cre", "cph"), email = "xie@yihui.name", comment = c(ORCID = "0000-0003-0645-5666")),
   person("Wush", "Wu", role = "ctb"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,6 @@
 # CHANGES IN xfun VERSION 0.25
 
+- Fixed a bug in `broken_packages()` (thanks, @PythonCoderUnicorn, rstudio/rmarkdown#1990).
 
 # CHANGES IN xfun VERSION 0.24
 

diff --git a/R/packages.R b/R/packages.R
@@ -150,7 +150,7 @@ broken_packages = function(reinstall = TRUE) {
       if (!loadable(p, new_session = TRUE)) p
     }))
     if (length(p) && reinstall) {
-      remove.packages(p, lib); pkg_install(pkgs, lib)
+      remove.packages(p, lib); pkg_install(p, lib = lib)
     }
     p
   }))