Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ecs workflow. #68

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Add ecs workflow. #68

merged 8 commits into from
Jan 26, 2024

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌

@terabytesoftw terabytesoftw requested a review from a team January 21, 2024 13:48
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Jan 21, 2024
@terabytesoftw terabytesoftw reopened this Jan 24, 2024
vjik
vjik requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need to use ECS?
PHP CS Fixer supports PER CS, why need something else?

vjik
vjik requested changes Jan 24, 2024
View reviewed changes
.github/workflows/ecs.yml Outdated Show resolved Hide resolved
.github/workflows/ecs.yml Outdated Show resolved Hide resolved
.github/workflows/ecs.yml Outdated Show resolved Hide resolved
.github/workflows/ecs.yml Outdated Show resolved Hide resolved
docs/ecs.md Show resolved Hide resolved
.github/workflows/ecs.yml Show resolved Hide resolved
@terabytesoftw terabytesoftw mentioned this pull request Jan 24, 2024
Merged
terabytesoftw and others added 2 commits January 24, 2024 14:13
@terabytesoftw @vjik
Update .github/workflows/ecs.yml
497b37c 
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@terabytesoftw @vjik
Update .github/workflows/ecs.yml
2e02cf9 
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@terabytesoftw terabytesoftw merged commit 0773021 into master Jan 26, 2024
@terabytesoftw terabytesoftw deleted the add-ecs-workflow- branch January 26, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark left review comments

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terabytesoftw @samdark @vjik