Remove result from ActiveRecordInterface methods: insert, upsert, save

src/AbstractActiveRecord.php

@@ -82,10 +82,8 @@ abstract protected function propertyValuesInternal(): array;
      * @throws InvalidArgumentException
      * @throws InvalidConfigException
      * @throws Throwable
-     *
-     * @return bool Whether the record inserted successfully.
      */
-    abstract protected function insertInternal(array|null $properties = null): bool;
+    abstract protected function insertInternal(array|null $properties = null): void;
 
     /**
      * Sets the value of the named property.
@@ -103,7 +101,7 @@ abstract protected function populateProperty(string $name, mixed $value): void;
     abstract protected function upsertInternal(
         array|null $insertProperties = null,
         array|bool $updateProperties = true,
-    ): bool;
+    ): void;
 
     public function createQuery(ActiveRecordInterface|string|null $modelClass = null): ActiveQueryInterface
     {
@@ -370,9 +368,9 @@ public function hasOne(ActiveRecordInterface|string $modelClass, array $link): A
         return $this->createRelationQuery($modelClass, $link, false);
     }
 
-    public function insert(array|null $properties = null): bool
+    public function insert(array|null $properties = null): void
     {
-        return $this->insertInternal($properties);
+        $this->insertInternal($properties);
     }
 
     public function isChanged(): bool
@@ -608,15 +606,14 @@ protected function retrieveRelation(string $name): ActiveRecordInterface|array|n
         return $this->related[$name] = $query->relatedRecords();
     }
 
-    public function save(array|null $properties = null): bool
+    public function save(array|null $properties = null): void
     {
         if ($this->isNewRecord()) {
-            return $this->insert($properties);
+            $this->insert($properties);
+            return;
         }
 
         $this->update($properties);
-
-        return true;
     }
 
     public function set(string $propertyName, mixed $value): void
@@ -794,9 +791,9 @@ public function updateCounters(array $counters): bool
         return true;
     }
 
-    public function upsert(array|null $insertProperties = null, array|bool $updateProperties = true): bool
+    public function upsert(array|null $insertProperties = null, array|bool $updateProperties = true): void
     {
-        return $this->upsertInternal($insertProperties, $updateProperties);
+        $this->upsertInternal($insertProperties, $updateProperties);
     }
 
     public function unlink(string $relationName, ActiveRecordInterface $linkedModel, bool $delete = false): void

src/ActiveRecord.php

@@ -159,7 +159,7 @@ protected function propertyValuesInternal(): array
         return get_object_vars($this);
     }
 
-    protected function insertInternal(array|null $properties = null): bool
+    protected function insertInternal(array|null $properties = null): void
     {
         if (!$this->isNewRecord()) {
             throw new InvalidCallException('The record is not new and cannot be inserted.');
@@ -168,10 +168,10 @@ protected function insertInternal(array|null $properties = null): bool
         $values = $this->newPropertyValues($properties);
         $primaryKeys = $this->db()->createCommand()->insertReturningPks($this->tableName(), $values);
 
-        return $this->populateRawValues($primaryKeys, $values);
+        $this->populateRawValues($primaryKeys, $values);
     }
 
-    protected function upsertInternal(array|null $insertProperties = null, array|bool $updateProperties = true): bool
+    protected function upsertInternal(array|null $insertProperties = null, array|bool $updateProperties = true): void
     {
         if (!$this->isNewRecord()) {
             throw new InvalidCallException('The record is not new and cannot be inserted.');
@@ -205,7 +205,7 @@ protected function upsertInternal(array|null $insertProperties = null, array|boo
         $returnedValues = $this->db()->createCommand()
             ->upsertReturning($this->tableName(), $insertValues, $updateProperties, $returnProperties);
 
-        return $this->populateRawValues($returnedValues);
+        $this->populateRawValues($returnedValues);
     }
 
     protected function populateProperty(string $name, mixed $value): void
@@ -214,23 +214,17 @@ protected function populateProperty(string $name, mixed $value): void
     }
 
     /**
-     * @psalm-param array<string, mixed>|false $rawValues
+     * @psalm-param array<string, mixed> $rawValues
      */
-    private function populateRawValues(array|false $rawValues, array $oldValues = []): bool
+    private function populateRawValues(array $rawValues, array $oldValues = []): void
     {
-        if ($rawValues === false) {
-            return false;
-        }
-
         $values = $this->phpTypecastValues($rawValues);
 
         foreach ($values as $name => $value) {
             $this->set($name, $value);
         }
 
         $this->assignOldValues(array_merge($oldValues, $values));
-
-        return true;
     }
 
     /**

src/ActiveRecordInterface.php

@@ -244,10 +244,8 @@ public function hasProperty(string $name): bool;
      * @throws InvalidCallException If the record {@see isNewRecord() is not new}.
      * @throws InvalidConfigException
      * @throws Throwable In case insert failed.
-     *
-     * @return bool Whether the record is inserted successfully.
      */
-    public function insert(array|null $properties = null): bool;
+    public function insert(array|null $properties = null): void;
 
     /**
      * Checks if any property returned by {@see propertyNames()} method has changed.
@@ -424,10 +422,8 @@ public function resetRelation(string $name): void;
      *
      * @param array|null $properties List of property names or name-values pairs that need to be saved.
      * Defaults to `null`, meaning all changed property values will be saved.
-     *
-     * @return bool Whether the saving succeeded (that's no validation errors occurred).
      */
-    public function save(array|null $properties = null): bool;
+    public function save(array|null $properties = null): void;
 
     /**
      * Sets the named property value.
@@ -562,10 +558,8 @@ public function updateAll(array $propertyValues, array|string $condition = [], a
      *
      * @throws InvalidConfigException
      * @throws Throwable In case query failed.
-     *
-     * @return bool Whether the record is inserted or updated successfully.
      */
-    public function upsert(array|null $insertProperties = null, array|bool $updateProperties = true): bool;
+    public function upsert(array|null $insertProperties = null, array|bool $updateProperties = true): void;
 
     /**
      * Destroys the relationship between two records.

src/Event/AfterInsert.php

@@ -15,9 +15,8 @@ final class AfterInsert extends AbstractEvent
 {
     /**
      * @param ActiveRecordInterface $model The model that has been inserted.
-     * @param bool $isSuccessful Whether the insert operation is successful.
      */
-    public function __construct(ActiveRecordInterface $model, public bool &$isSuccessful)
+    public function __construct(ActiveRecordInterface $model)
     {
         parent::__construct($model);
     }

src/Event/AfterSave.php

@@ -15,9 +15,8 @@ final class AfterSave extends AbstractEvent
 {
     /**
      * @param ActiveRecordInterface $model The model that was saved.
-     * @param bool $isSuccessful Whether the save operation was successful.
      */
-    public function __construct(ActiveRecordInterface $model, public bool &$isSuccessful)
+    public function __construct(ActiveRecordInterface $model)
     {
         parent::__construct($model);
     }

src/Event/AfterUpsert.php

@@ -15,9 +15,8 @@ final class AfterUpsert extends AbstractEvent
 {
     /**
      * @param ActiveRecordInterface $model The model that was upserted.
-     * @param bool $isSuccessful Whether the upsert operation was successful.
      */
-    public function __construct(ActiveRecordInterface $model, public bool &$isSuccessful)
+    public function __construct(ActiveRecordInterface $model)
     {
         parent::__construct($model);
     }

src/Trait/EventsTrait.php

@@ -54,20 +54,18 @@ public function delete(): int
         return $result;
     }
 
-    public function insert(array|null $properties = null): bool
+    public function insert(array|null $properties = null): void
     {
         $eventDispatcher = EventDispatcherProvider::get(static::class);
         $eventDispatcher->dispatch($event = new BeforeInsert($this, $properties));
 
         if ($event->isDefaultPrevented()) {
-            return $event->getReturnValue() ?? false;
+            return;
         }
 
-        $result = parent::insert($properties);
+        parent::insert($properties);
 
-        $eventDispatcher->dispatch(new AfterInsert($this, $result));
-
-        return $result;
+        $eventDispatcher->dispatch(new AfterInsert($this));
     }
 
     public function populateRecord(array|object $data): static
@@ -109,20 +107,18 @@ public static function query(ActiveRecordInterface|Closure|null|string $modelCla
         return $query;
     }
 
-    public function save(array|null $properties = null): bool
+    public function save(array|null $properties = null): void
     {
         $eventDispatcher = EventDispatcherProvider::get(static::class);
         $eventDispatcher->dispatch($event = new BeforeSave($this, $properties));
 
         if ($event->isDefaultPrevented()) {
-            return $event->getReturnValue() ?? false;
+            return;
         }
 
-        $result = parent::save($properties);
-
-        $eventDispatcher->dispatch(new AfterSave($this, $result));
+        parent::save($properties);
 
-        return $result;
+        $eventDispatcher->dispatch(new AfterSave($this));
     }
 
     public function update(array|null $properties = null): int
@@ -141,19 +137,17 @@ public function update(array|null $properties = null): int
         return $result;
     }
 
-    public function upsert(array|null $insertProperties = null, array|bool $updateProperties = true): bool
+    public function upsert(array|null $insertProperties = null, array|bool $updateProperties = true): void
     {
         $eventDispatcher = EventDispatcherProvider::get(static::class);
         $eventDispatcher->dispatch($event = new BeforeUpsert($this, $insertProperties, $updateProperties));
 
         if ($event->isDefaultPrevented()) {
-            return $event->getReturnValue() ?? false;
+            return;
         }
 
-        $result = parent::upsert($insertProperties, $updateProperties);
-
-        $eventDispatcher->dispatch(new AfterUpsert($this, $result));
+        parent::upsert($insertProperties, $updateProperties);
 
-        return $result;
+        $eventDispatcher->dispatch(new AfterUpsert($this));
     }
 }

tests/ActiveQueryTest.php

@@ -2065,12 +2065,12 @@ public function testOldPropertyAfterInsertAndUpdate(): void
         ]);
 
         $this->assertNull($customer->oldValue('name'));
-        $this->assertTrue($customer->save());
+        $customer->save();
         $this->assertSame('Jack', $customer->oldValue('name'));
 
         $customer->set('name', 'Harry');
 
-        $this->assertTrue($customer->save());
+        $customer->save();
         $this->assertSame('Harry', $customer->oldValue('name'));
     }