Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method registerCustom() to AssetManager::class. #113

Merged
merged 8 commits into from
Jan 23, 2023
Merged

Add method registerCustom() to AssetManager::class. #113

merged 8 commits into from
Jan 23, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 99.63% // Head: 99.67% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (08f8bca) compared to base (016f54f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #113      +/-   ##
============================================
+ Coverage     99.63%   99.67%   +0.04%     
- Complexity      248      249       +1     
============================================
  Files             8        8              
  Lines           546      624      +78     
============================================
+ Hits            544      622      +78     
  Misses            2        2              
Impacted Files Coverage Δ
src/AssetManager.php 100.00% <100.00%> (ø)
src/AssetLoader.php 100.00% <0.00%> (ø)
src/AssetConverter.php 100.00% <0.00%> (ø)
src/AssetRegistrar.php 100.00% <0.00%> (ø)
src/Exporter/JsonAssetExporter.php 100.00% <0.00%> (ø)
src/Exporter/WebpackAssetExporter.php 100.00% <0.00%> (ø)
src/AssetPublisher.php 97.43% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/AssetManager.php Outdated Show resolved Hide resolved
src/AssetManager.php Outdated Show resolved Hide resolved
tests/AssetManagerTest.php Outdated Show resolved Hide resolved
terabytesoftw and others added 5 commits January 23, 2023 11:54
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
@terabytesoftw terabytesoftw requested review from samdark and a team January 23, 2023 15:02
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Jan 23, 2023
.github/workflows/bc.yml Outdated Show resolved Hide resolved
@vjik vjik merged commit 69a6383 into yiisoft:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants