(#7) Added Redis cluster support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
s1lver
commented
Aug 24, 2022
•
s1lver
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | #7 |
- Changed CI to run single and clustered Redis
- Added identical tests with a connection to the Redis cluster
- Updated predis to 2.0 (Update predis/predis requirement from ^1.1 to ^2.0 #4)
- Updated predis to 2.1 (Update predis/predis requirement from ^1.1 to ^2.1 #12)
- Added base support Redis cluster
# Conflicts: # .github/workflows/build.yml
…leteThrowExceptionForInvalidKey
…leteMultipleThrowExceptionForInvalidKeys, testGetMultipleThrowExceptionForEmptyArray, testSetMultipleThrowExceptionForEmptyArray tests
|
Ready for review/merge? |
s1lver
changed the title
# Conflicts: # src/RedisCache.php
samdark
reviewed
Jul 10, 2023
|
Also, it would be great to mention cluster support in README. |
|
Code overall is 👍 |
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.