Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method KetsetPaginator::withSort() must check that sort is not null #202

Closed
vjik opened this issue Sep 29, 2024 · 0 comments · Fixed by #209
Closed

Method KetsetPaginator::withSort() must check that sort is not null #202

vjik opened this issue Sep 29, 2024 · 0 comments · Fixed by #209
Assignees
@samdark

Comments

@vjik
Copy link
Member

vjik commented Sep 29, 2024

Keyset paginator can work with sorted data only. Need a check the same as in the constructor.
@samdark samdark self-assigned this Sep 30, 2024
@samdark samdark linked a pull request Oct 17, 2024 that will close this issue
Fix #202: Check that correct sort is passed to withSort() of keyset paginator #209
Merged
@vjik vjik closed this as completed in #209 Oct 19, 2024
vjik pushed a commit that referenced this issue Oct 19, 2024
@samdark
Fix #202: Check that correct sort is passed to withSort() of keyset…
8739893 
… paginator (#209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samdark samdark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #202: Check that correct sort is passed to withSort() of keyset paginator yiisoft/data
2 participants
@samdark @vjik