Skip to content

Conversation

@Tigrov
Copy link
Member

@Tigrov Tigrov commented Feb 6, 2024

Main PR

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Feb 6, 2024

PR Summary

  • Modified testing methods in CommandTest.php
    To enhance the effectiveness of these test, we've introduced new input parameters. These include a list of values we expect the command to return ($expectedValues) and the count of these expected values ($expectedCount).

  • Adjusted testing methods in QueryBuilderTest.php
    This update includes additional inputs for our testing methods. We now test using specific parameters ($params), the expected SQL query as a text ($expectedSql), and the expected parameters that should be provided to the query ($expectedParams). This ensures more robust and comprehensive testing of our SQL query building functionality.

@codecov
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (e1275ac) to head (1ec1e06).

❗ Current head 1ec1e06 differs from pull request most recent head d6f3939. Consider uploading reports for the commit d6f3939 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #255      +/-   ##
============================================
+ Coverage     98.02%   98.15%   +0.12%     
- Complexity      175      186      +11     
============================================
  Files            16       18       +2     
  Lines           556      595      +39     
============================================
+ Hits            545      584      +39     
  Misses           11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need line in changelog

@vjik vjik merged commit a8fb606 into master Apr 12, 2024
@vjik vjik deleted the fix-update-with-expressions branch April 12, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants