Skip to content

Conversation

@Tigrov
Copy link
Member

@Tigrov Tigrov commented May 30, 2024

Preparing to combine Column and ColumnSchema in one class

Related PR

Q A
Is bugfix?
New feature? ✔️/❌
Breaks BC?
Fixed issues yiisoft/db#854

@codecov
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (85c27c5) to head (32c617b).

Current head 32c617b differs from pull request most recent head d1e7fe3

Please upload reports for the commit d1e7fe3 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #349   +/-   ##
=========================================
  Coverage     99.26%   99.27%           
  Complexity      282      282           
=========================================
  Files            23       23           
  Lines           821      824    +3     
=========================================
+ Hits            815      818    +3     
  Misses            6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jun 22, 2024
@Tigrov Tigrov requested a review from a team June 22, 2024 04:25
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add info to changelog and upgrade

@Tigrov Tigrov merged commit 48dbbe8 into master Jun 23, 2024
@Tigrov Tigrov deleted the add-method-chaining branch June 23, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants