Consider platform integer size in ColumnBuilder::bigint() + Throw exception on "unsigned" column usage
#460
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
============================================
- Coverage 99.67% 99.45% -0.22%
- Complexity 316 320 +4
============================================
Files 36 36
Lines 919 925 +6
============================================
+ Hits 916 920 +4
- Misses 3 5 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vjik
changed the title
ColumnBuilder::bigint()ColumnBuilder::bigint() + Throw exception on "unsigned" column usage
| if ($column->isUnsigned()) { | ||
| throw new NotSupportedException('The "unsigned" attribute is not supported by PostgreSQL.'); | ||
| } |
There was a problem hiding this comment.
I'd just ignore this. Or as an option we can add CHECK (column >= 0)
There was a problem hiding this comment.
Unsigned columns often usage for big values. Exception will alert the user that this is not available.
| public function fromPseudoType(string $pseudoType, array $info = []): ColumnInterface | ||
| { | ||
| // PostgreSQL doesn't support unsigned types | ||
| return parent::fromPseudoType($pseudoType, $info)->unsigned(false); |
There was a problem hiding this comment.
I do not think that this is correct. There are ways how to get unsigned type (with check)
There was a problem hiding this comment.
Unsigned in most cases (almost always?) is added for store big values, not for non-negative values constraint.
Related to yiisoft/db#1095