Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
- New #355: Use `DateTimeColumn` class for datetime column types (@Tigrov)
- New #356, #357: Implement `DMLQueryBuilder::upsertReturning()` method (@Tigrov)
- Enh #356, #357: Refactor `Command::insertWithReturningPks()` and `DMLQueryBuilder::upsert()` methods (@Tigrov)
- Enh #360: Implement `DMLQueryBuilder::insertWithReturningPks()` method (@Tigrov)
- Enh #360, #361: Implement `DMLQueryBuilder::insertReturningPks()` method (@Tigrov)
- Chg #362: Replace column and table name quote character from ` to " (@Tigrov)

## 1.2.0 March 21, 2024
Expand Down
2 changes: 1 addition & 1 deletion src/DMLQueryBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*/
final class DMLQueryBuilder extends AbstractDMLQueryBuilder
{
public function insertWithReturningPks(string $table, array|QueryInterface $columns, array &$params = []): string
public function insertReturningPks(string $table, array|QueryInterface $columns, array &$params = []): string
{
$insertSql = $this->insert($table, $columns, $params);
$tableSchema = $this->schema->getTableSchema($table);
Expand Down
2 changes: 1 addition & 1 deletion tests/Provider/QueryBuilderProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public static function insert(): array
return $insert;
}

public static function insertWithReturningPks(): array
public static function insertReturningPks(): array
{
return [
'regular-values' => [
Expand Down
6 changes: 3 additions & 3 deletions tests/QueryBuilderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -509,15 +509,15 @@ public function testInsert(
parent::testInsert($table, $columns, $params, $expectedSQL, $expectedParams);
}

#[DataProviderExternal(QueryBuilderProvider::class, 'insertWithReturningPks')]
public function testInsertWithReturningPks(
#[DataProviderExternal(QueryBuilderProvider::class, 'insertReturningPks')]
public function testInsertReturningPks(
string $table,
array|QueryInterface $columns,
array $params,
string $expectedSQL,
array $expectedParams
): void {
parent::testInsertWithReturningPks($table, $columns, $params, $expectedSQL, $expectedParams);
parent::testInsertReturningPks($table, $columns, $params, $expectedSQL, $expectedParams);
}

public function testRenameColumn(): void
Expand Down
Loading