Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
- Enh #360, #361: Implement `DMLQueryBuilder::insertReturningPks()` method (@Tigrov)
- Chg #362: Replace column and table name quote character from ` to " (@Tigrov)
- Enh #368: Provide `yiisoft/db-implementation` virtual package (@vjik)
- Enh #371: Adapt to conditions refactoring in `yiisoft/db` package (@vjik)

## 1.2.0 March 21, 2024

Expand Down
19 changes: 13 additions & 6 deletions src/Builder/JsonOverlapsConditionBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,24 @@
use InvalidArgumentException;
use Yiisoft\Db\Exception\InvalidConfigException;
use Yiisoft\Db\Exception\NotSupportedException;
use Yiisoft\Db\Expression\ExpressionBuilderInterface;
use Yiisoft\Db\Expression\ExpressionInterface;
use Yiisoft\Db\Expression\JsonExpression;
use Yiisoft\Db\QueryBuilder\Condition\Builder\AbstractOverlapsConditionBuilder;
use Yiisoft\Db\QueryBuilder\Condition\JsonOverlapsCondition;
use Yiisoft\Db\QueryBuilder\QueryBuilderInterface;

/**
* Builds expressions for {@see JsonOverlapsCondition} for SQLite Server.
*
* @extends AbstractOverlapsConditionBuilder<JsonOverlapsCondition>
* @implements ExpressionBuilderInterface<JsonOverlapsCondition>
*/
final class JsonOverlapsConditionBuilder extends AbstractOverlapsConditionBuilder
final class JsonOverlapsConditionBuilder implements ExpressionBuilderInterface
{
public function __construct(
private readonly QueryBuilderInterface $queryBuilder,
) {
}

/**
* Build SQL for {@see JsonOverlapsCondition}.
*
Expand All @@ -32,13 +38,14 @@ final class JsonOverlapsConditionBuilder extends AbstractOverlapsConditionBuilde
*/
public function build(ExpressionInterface $expression, array &$params = []): string
{
$column = $this->prepareColumn($expression->getColumn());
$values = $expression->getValues();
$column = $expression->column instanceof ExpressionInterface
? $this->queryBuilder->buildExpression($expression->column)
: $this->queryBuilder->getQuoter()->quoteColumnName($expression->column);

$values = $expression->values;
if (!$values instanceof ExpressionInterface) {
$values = new JsonExpression($values);
}

$values = $this->queryBuilder->buildExpression($values, $params);

return "EXISTS(SELECT value FROM json_each($column) INTERSECT SELECT value FROM json_each($values))=1";
Expand Down
2 changes: 1 addition & 1 deletion src/Builder/LikeConditionBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function __construct(QueryBuilderInterface $queryBuilder)

public function build(ExpressionInterface $expression, array &$params = []): string
{
if ($expression->getCaseSensitive() === true) {
if ($expression->caseSensitive === true) {
throw new NotSupportedException('SQLite doesn\'t support case-sensitive "LIKE" conditions.');
}
return parent::build($expression, $params);
Expand Down
2 changes: 1 addition & 1 deletion src/DQLQueryBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
use Yiisoft\Db\Query\QueryInterface;
use Yiisoft\Db\QueryBuilder\AbstractDQLQueryBuilder;
use Yiisoft\Db\QueryBuilder\Condition\InCondition;
use Yiisoft\Db\QueryBuilder\Condition\JsonOverlapsCondition;
use Yiisoft\Db\QueryBuilder\Condition\LikeCondition;
use Yiisoft\Db\QueryBuilder\Condition\JsonOverlapsCondition;
use Yiisoft\Db\Sqlite\Builder\InConditionBuilder;
use Yiisoft\Db\Sqlite\Builder\JsonOverlapsConditionBuilder;
use Yiisoft\Db\Sqlite\Builder\LikeConditionBuilder;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
/**
* @group sqlite
*/
final class InconditionBuilderTest extends TestCase
final class InConditionBuilderTest extends TestCase
{
use TestTrait;

Expand Down
Loading