-
-
Notifications
You must be signed in to change notification settings - Fork 43
Refactor DSN classes
#1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DSN classes
#1005
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1005 +/- ##
============================================
+ Coverage 92.64% 98.94% +6.29%
+ Complexity 1622 1599 -23
============================================
Files 99 97 -2
Lines 4108 4071 -37
============================================
+ Hits 3806 4028 +222
+ Misses 302 43 -259 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samdark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, that's a good move 👍. We lose the ability to get components of the DSN directly though, but if we assume that all DSNs follow the same naming schema (is that true? 🤔) then, if needed, we can parse it.
|
Related PRs
Dsnclass db-sqlite#373DSNclasses db-mysql#410Dsnclass db-pgsql#427Dsnclass db-mssql#378Dsnclass db-oracle#344