Skip to content

Conversation

@Tigrov
Copy link
Member

@Tigrov Tigrov commented Jul 22, 2025

@Tigrov Tigrov requested a review from a team July 22, 2025 18:43
@Tigrov Tigrov added the status:code review The pull request needs review. label Jul 22, 2025
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (9f54f4b) to head (0d2514a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1005      +/-   ##
============================================
+ Coverage     92.64%   98.94%   +6.29%     
+ Complexity     1622     1599      -23     
============================================
  Files            99       97       -2     
  Lines          4108     4071      -37     
============================================
+ Hits           3806     4028     +222     
+ Misses          302       43     -259     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tigrov Tigrov requested a review from vjik July 23, 2025 09:11
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, that's a good move 👍. We lose the ability to get components of the DSN directly though, but if we assume that all DSNs follow the same naming schema (is that true? 🤔) then, if needed, we can parse it.

@Tigrov
Copy link
Member Author

Tigrov commented Jul 23, 2025

Overall, that's a good move 👍. We lose the ability to get components of the DSN directly though, but if we assume that all DSNs follow the same naming schema (is that true? 🤔) then, if needed, we can parse it.

Dsn instants before also converted into strings due to the Driver classes acept only strings.

@Tigrov Tigrov merged commit 333f44d into master Jul 23, 2025
68 checks passed
@Tigrov Tigrov deleted the refactor-dsn branch July 23, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants