Skip to content

Add Equals condition. Remove Hash condition in favor Equals and In usage #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vjik merged 17 commits into from
Jul 30, 2025
Merged

Add Equals condition. Remove Hash condition in favor Equals and In usage #1007

vjik merged 17 commits into from
Jul 30, 2025

Conversation

@vjik
Copy link
Member

@vjik vjik commented Jul 29, 2025 •
edited
Loading

@codecov
Copy link

codecov bot commented Jul 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (73f0052) to head (33531e5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1007      +/-   ##
============================================
- Coverage     98.94%   98.89%   -0.05%     
- Complexity     1599     1608       +9     
============================================
  Files            97       97              
  Lines          4070     4090      +20     
============================================
+ Hits           4027     4045      +18     
- Misses           43       45       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team July 29, 2025 14:13
@vjik vjik added the status:code review The pull request needs review. label Jul 29, 2025
Tigrov
Tigrov approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@Tigrov Tigrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

This was referenced Jul 29, 2025
Merged
Merged
@vjik vjik requested a review from Tigrov July 29, 2025 19:53
Tigrov
Tigrov approved these changes Jul 29, 2025
View reviewed changes
vjik and others added 4 commits July 29, 2025 23:17
@vjik @Tigrov
Update tests/Db/QueryBuilder/Condition/EqualsTest.php
29f41e4 
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
@vjik @Tigrov
Update tests/Db/QueryBuilder/Condition/EqualsTest.php
22546eb 
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
@vjik @Tigrov
Update tests/Db/QueryBuilder/Condition/EqualsTest.php
30cc515 
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
@vjik @Tigrov
Update tests/Db/QueryBuilder/Condition/EqualsTest.php
17cdac6 
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
samdark
samdark approved these changes Jul 29, 2025
View reviewed changes
vjik and others added 2 commits July 30, 2025 00:02
@vjik
fix
1b42af6
@vjik @samdark
Update src/QueryBuilder/AbstractDQLQueryBuilder.php
33531e5 
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
This was referenced Jul 29, 2025
Merged
Merged
Merged
@vjik vjik merged commit 69832fb into master Jul 30, 2025
67 of 114 checks passed
@vjik vjik deleted the split-hash branch July 30, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samdark samdark samdark approved these changes

@Tigrov Tigrov Tigrov approved these changes

Assignees

No one assigned

Labels

status:code review The pull request needs review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vjik @samdark @Tigrov @StyleCIBot