Fix column definition parsing in cases with brackets and escaped quotes #1109
+53
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1109 +/- ##
=============================================
+ Coverage 84.58% 98.62% +14.03%
Complexity 1648 1648
=============================================
Files 119 119
Lines 4268 4283 +15
=============================================
+ Hits 3610 4224 +614
+ Misses 658 59 -599 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 27, 2025
samdark
approved these changes
Nov 27, 2025
Tigrov
approved these changes
Nov 27, 2025
| $matches[1], | ||
| ); | ||
|
|
||
| return ['enumValues' => $values]; |
Member
There was a problem hiding this comment.
Suggested change
| return ['enumValues' => $values]; | |
| return ['values' => $values]; |
Member
Author
There was a problem hiding this comment.
I'll change it in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs: