Rename batchInsert() to insertBatch() and change paremeters order
#829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e` and `CommandInterface`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #829 +/- ##
============================================
- Coverage 99.56% 99.44% -0.13%
- Complexity 1320 1323 +3
============================================
Files 64 64
Lines 3246 3251 +5
============================================
+ Hits 3232 3233 +1
- Misses 14 18 +4 ☔ View full report in Codecov by Sentry. |
This was referenced Apr 28, 2024
vjik
requested changes
Apr 30, 2024
src/Command/AbstractCommand.php
Outdated
| * | ||
| * @psalm-param BatchValues $rows | ||
| * | ||
| * @deprecated Use (@see insertBatch()) instead. It will be removed in version 3.0.0. |
Member
There was a problem hiding this comment.
After merge PR need to create new issue about remove it.
| * @psalm-param BatchValues $rows | ||
| * @psalm-param ParamsType $params | ||
| * | ||
| * @deprecated Use (@see insertBatch()) instead. It will be removed in version 3.0.0. |
Member
There was a problem hiding this comment.
After merge PR need to create new issue about remove it.
Member
Author
Done |
vjik
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
batchInsert()toinsertBatch()inDMLQueryBuilderInterfaceandCommandInterface$table, $columns, $rowsto$table, $rows, $columns[]for$columnsparameterFrom
batchInsert(string $table, array $columns, iterable $rows)to
insertBatch(string $table, iterable $rows, array $columns = [])Related PRs