Skip to content

Refactor array, structured and JSON expressions. #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tigrov merged 19 commits into from
Mar 7, 2025

Improve

165e79c
Select commit
Loading
Failed to load commit list.
Merged

Refactor array, structured and JSON expressions. #929

Improve
165e79c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 2, 2025 in 1s

99.26% (-0.36%) compared to 318ec5c

View this Pull Request on Codecov

99.26% (-0.36%) compared to 318ec5c

Details

Codecov Report

Attention: Patch coverage is 94.75524% with 15 lines in your changes missing coverage. Please review.

Project coverage is 99.26%. Comparing base (318ec5c) to head (165e79c).

Files with missing lines Patch % Lines
...Expression/AbstractStructuredExpressionBuilder.php 80.00% 7 Missing ⚠️
src/Expression/AbstractArrayExpressionBuilder.php 72.22% 5 Missing ⚠️
src/Schema/Data/AbstractStructuredLazyArray.php 90.00% 2 Missing ⚠️
src/Schema/Data/AbstractLazyArray.php 94.44% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #929      +/-   ##
============================================
- Coverage     99.62%   99.26%   -0.36%     
- Complexity     1490     1539      +49     
============================================
  Files            81       98      +17     
  Lines          3689     3805     +116     
============================================
+ Hits           3675     3777     +102     
- Misses           14       28      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov