Skip to content

Conversation

@evil1
Copy link
Contributor

@evil1 evil1 commented Mar 28, 2025

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️
Fixed issues #888

Relative PRs:

@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 94.84536% with 5 lines in your changes missing coverage. Please review.

Project coverage is 99.18%. Comparing base (43abebf) to head (b41aa4c).

Files with missing lines Patch % Lines
src/QueryBuilder/AbstractDMLQueryBuilder.php 96.72% 2 Missing ⚠️
src/QueryBuilder/AbstractQueryBuilder.php 66.66% 2 Missing ⚠️
src/Command/AbstractCommand.php 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #948      +/-   ##
============================================
- Coverage     99.24%   99.18%   -0.07%     
- Complexity     1554     1571      +17     
============================================
  Files            98      100       +2     
  Lines          3852     3913      +61     
============================================
+ Hits           3823     3881      +58     
- Misses           29       32       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik added the status:under development Someone is working on a pull request. label Apr 16, 2025
final class BatchCommand
{
/**
* @param CommandInterface[] $commands Query statements for execution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param CommandInterface[] $commands Query statements for execution
* @param CommandInterface[] $commands Query statements for execution.

}

/**
* @return ConnectionInterface The query builder instance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @return ConnectionInterface The query builder instance.
* @return ConnectionInterface The connection instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:under development Someone is working on a pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants