Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter name binding #87
base: master
Are you sure you want to change the base?
Parameter name binding #87
Changes from 7 commits
7ea68b6
28ca701
8e2527c
1164dfa
5f647b5
861988d
679246c
cb0b647
e1d258e
0e2312c
986742f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that feature can degrade performance. Suggest to do it optional or need check performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xepozz would you mind running a comparison benchmark for it?
Check warning on line 108 in src/DefinitionStorage.php
GitHub Actions / mutation / PHP 8.3-ubuntu-latest
Check warning on line 108 in src/DefinitionStorage.php
GitHub Actions / mutation / PHP 8.3-ubuntu-latest
Check warning on line 108 in src/DefinitionStorage.php
GitHub Actions / mutation / PHP 8.3-ubuntu-latest
Check warning on line 108 in src/DefinitionStorage.php
GitHub Actions / mutation / PHP 8.3-ubuntu-latest
Check warning on line 108 in src/DefinitionStorage.php
GitHub Actions / mutation / PHP 8.3-ubuntu-latest
Check warning on line 108 in src/DefinitionStorage.php
GitHub Actions / mutation / PHP 8.3-ubuntu-latest
Check warning on line 109 in src/DefinitionStorage.php
GitHub Actions / mutation / PHP 8.3-ubuntu-latest
Check warning on line 109 in src/DefinitionStorage.php
GitHub Actions / mutation / PHP 8.3-ubuntu-latest
Check warning on line 109 in src/DefinitionStorage.php
GitHub Actions / mutation / PHP 8.3-ubuntu-latest
Check warning on line 121 in src/DefinitionStorage.php
Codecov / codecov/patch
src/DefinitionStorage.php#L113-L121
Check warning on line 123 in src/DefinitionStorage.php
Codecov / codecov/patch
src/DefinitionStorage.php#L123
Check warning on line 126 in src/DefinitionStorage.php
Codecov / codecov/patch
src/DefinitionStorage.php#L126
Check warning on line 254 in src/DefinitionStorage.php
GitHub Actions / mutation / PHP 8.3-ubuntu-latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems, this changes not need in this PR.
Check warning on line 57 in src/Helpers/Normalizer.php
Codecov / codecov/patch
src/Helpers/Normalizer.php#L57