-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy services #232
base: master
Are you sure you want to change the base?
Lazy services #232
Conversation
xepozz
commented
Aug 1, 2021
•
edited
Loading
edited
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ❌ |
Related issues | #197, yiisoft/definitions#58 |
Tests fail because of yiisoft/factory#116 isn't in master |
# Conflicts: # src/Container.php
# Conflicts: # composer.json # src/Container.php # src/ExtensibleService.php # tests/Unit/Helpers/DefinitionParserTest.php
# Conflicts: # src/Container.php
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
=============================================
- Coverage 100.00% 98.54% -1.46%
- Complexity 161 168 +7
=============================================
Files 11 11
Lines 466 481 +15
=============================================
+ Hits 466 474 +8
- Misses 0 7 +7 ☔ View full report in Codecov by Sentry. |
Adding benchmarking would be great. |
use Yiisoft\Di\Tests\Support\EngineMarkOne; | ||
|
||
class LazyServiceContainerTest extends TestCase | ||
{ | ||
protected function setUp(): void | ||
{ | ||
if (!class_exists(\ProxyManager\Factory\LazyLoadingValueHolderFactory::class)) { | ||
$this->markTestSkipped('You should install `ocramius/proxy-manager` if you want to use lazy services.'); | ||
if (!class_exists(LazyLoadingValueHolderFactory::class)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always false
in tests
* improve * Fix psalm