Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy services #232

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Lazy services #232

wants to merge 27 commits into from

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Aug 1, 2021

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Related issues #197, yiisoft/definitions#58

src/Container.php Outdated Show resolved Hide resolved
src/Container.php Outdated Show resolved Hide resolved
@xepozz xepozz requested a review from a team August 1, 2021 10:35
@xepozz xepozz added the status:code review The pull request needs review. label Aug 1, 2021
@xepozz
Copy link
Member Author

xepozz commented Aug 1, 2021

Tests fail because of yiisoft/factory#116 isn't in master

@xepozz xepozz marked this pull request as draft August 10, 2021 21:28
src/Container.php Outdated Show resolved Hide resolved
xepozz and others added 4 commits November 20, 2022 11:04
# Conflicts:
#	composer.json
#	src/Container.php
#	src/ExtensibleService.php
#	tests/Unit/Helpers/DefinitionParserTest.php
@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 98.54%. Comparing base (aeb0856) to head (fedff5e).

❗ Current head fedff5e differs from pull request most recent head 51fefa2. Consider uploading reports for the commit 51fefa2 to get more accurate results

Files Patch % Lines
src/Container.php 53.33% 7 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              master     #232      +/-   ##
=============================================
- Coverage     100.00%   98.54%   -1.46%     
- Complexity       161      168       +7     
=============================================
  Files             11       11              
  Lines            466      481      +15     
=============================================
+ Hits             466      474       +8     
- Misses             0        7       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustamwin
Copy link
Member

Adding benchmarking would be great.

@xepozz xepozz marked this pull request as ready for review December 13, 2022 19:45
@vjik vjik added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Jul 29, 2023
use Yiisoft\Di\Tests\Support\EngineMarkOne;

class LazyServiceContainerTest extends TestCase
{
protected function setUp(): void
{
if (!class_exists(\ProxyManager\Factory\LazyLoadingValueHolderFactory::class)) {
$this->markTestSkipped('You should install `ocramius/proxy-manager` if you want to use lazy services.');
if (!class_exists(LazyLoadingValueHolderFactory::class)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always false in tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:under development Someone is working on a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants