Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double validation #51

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Fix double validation #51

merged 3 commits into from
Aug 20, 2024

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC?

@arogachev arogachev self-assigned this Aug 12, 2024
@arogachev arogachev added type:bug Bug type:feature New feature labels Aug 13, 2024
@arogachev arogachev added this to the 1.0 milestone Aug 13, 2024
@arogachev arogachev marked this pull request as ready for review August 13, 2024 08:58
@@ -138,6 +151,37 @@ public function populateFromPost(
return $this->populate($model, $request->getParsedBody(), $map, $strict, $scope);
}

/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined it with other public methods, no other changes here.

@arogachev arogachev requested a review from a team August 13, 2024 09:00
@arogachev arogachev added the status:code review The pull request needs review. label Aug 13, 2024
@arogachev arogachev requested review from a team and vjik August 13, 2024 11:51
@arogachev arogachev merged commit cd4b7fe into master Aug 20, 2024
16 checks passed
@arogachev arogachev deleted the 50-double-validation-fix branch August 20, 2024 07:37
rossaddison added a commit to rossaddison/invoice that referenced this pull request Aug 22, 2024
Bug: Quote and Invoice not able to add rows

Fix: Apply yiisoft/form-model#51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review. type:bug Bug type:feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation is done twice when using FormHydrator::populateAndValidate() method and ValidatingHydrator
2 participants