Attribute sorting

[Gerych1984]

Good afternoon. There is an error for <img loading=“lazy”> (maybe somewhere else) in the Html + Vue bundle. For example, there are several images like this that are initially hidden in inactive tabs and as a consequence should not be loaded until the tab is inactive and/or the user scrolls to them. But - in the browser console you can see that they are loaded immediately, as if they don't have the loading=lazy attribute (and vue is the initiator). The vue authors won't fix this and say to just put loading before src (and it work), but this is impossible to do because of forced attribute sorting. Is this sorting so necessary?

[samdark]

@vjik is there anything special about attributes sorting? If not, I'd avoid it.

[vjik]

is there anything special about attributes sorting? If not, I'd avoid it.

I don't know why it needed. Seems, it's yii2 legacy: https://github.com/yiisoft/yii2/blob/a7b2a4ef05aab3ac8018ed92c4418df3f4acb596/framework/helpers/BaseHtml.php#L58

[samdark]

Alright. Let's get rid of it.

[samdark]

Decided not to remove ordering for now.

[Gerych1984]

Decided not to remove ordering for now.

Did all the tests in the other packages break down? )

[samdark]

?

[Gerych1984]

?

I just imagined how many tests would break in this and the packages that depend on it

[samdark]

None should break if we're not removing the sorting but taking loading into account.

[vjik]

In general, order of attributes is not significant. I think we should remove sorting of attributes in next major version.

[samdark]

But first we should dig into commits where it was added in Yii2 to understand why.