Skip to content

Fix #234: Remove attribute sorting #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FrankiFixx wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fix #234: Remove attribute sorting #236

FrankiFixx wants to merge 12 commits into from

Conversation

@FrankiFixx
Copy link
Contributor

@FrankiFixx FrankiFixx commented Jan 14, 2025 •
edited by samdark
Loading

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixes #234

@codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d00e8ee) to head (7c949b0).

Additional details and impacted files 
@@             Coverage Diff             @@
##              master      #236   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       829       826    -3     
===========================================
  Files             89        89           
  Lines           2229      2223    -6     
===========================================
- Hits            2229      2223    -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

samdark
samdark approved these changes Jan 15, 2025
View reviewed changes
@FrankiFixx @samdark
Update CHANGELOG.md
3cce673 
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
@samdark samdark requested a review from vjik January 15, 2025 18:03
@vjik vjik changed the title Fix 234 issue Fix #234: Remove attribute sorting Jan 16, 2025
vjik
vjik approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

We'll merge it after other BC-break changes are added.

@vjik vjik added the status:ready for merge The pull request is OK to be merged. label Jan 16, 2025
@vjik vjik added this to the 4.0 milestone Mar 8, 2025
@vjik vjik added the severity:BC breaking Breaks backwards compatibility label Jan 5, 2026
@vjik vjik mentioned this pull request Jan 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

Assignees

No one assigned

Labels

severity:BC breaking Breaks backwards compatibility status:ready for merge The pull request is OK to be merged.

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@FrankiFixx @samdark @vjik @dev05icontext-commits