Performance optimizations

phpbench.json

@@ -0,0 +1,5 @@
+{
+    "$schema": "./vendor/phpbench/phpbench/phpbench.schema.json",
+    "runner.bootstrap": "vendor/autoload.php",
+    "runner.path": "tests/Benchmark"
+}

src/Html.php

@@ -1674,14 +1674,15 @@
      */
     public static function renderTagAttributes(array $attributes): string
     {
         if (count($attributes) > 1) {
-            $sorted = [];
+            $ordered = [];
             foreach (self::ATTRIBUTE_ORDER as $name) {
                 if (isset($attributes[$name])) {
-                    $sorted[$name] = $attributes[$name];
+                    $ordered[$name] = $attributes[$name];
+                    unset($attributes[$name]);
                 }
             }
-            $attributes = array_merge($sorted, $attributes);
+            $attributes = $ordered + $attributes;
         }
 
         $html = '';
@@ -1698,11 +1699,11 @@
                     /** @psalm-var array<array-key, scalar[]|string|Stringable|null> $value */
                     foreach ($value as $n => $v) {
                         if (!isset($v)) {
                             continue;
                         }
                         $fullName = "$name-$n";
                         if (in_array($fullName, self::ATTRIBUTES_WITH_CONCATENATED_VALUES, true)) {
                             $html .= self::renderAttribute(
                                 $fullName,
                                 self::encodeAttribute(
                                     is_array($v) ? implode(' ', $v) : $v,
@@ -1925,13 +1926,16 @@
      */
     public static function cssStyleFromArray(array $style): ?string
     {
-        $result = '';
+        if (empty($style)) {
+            return null;
+        }
+
+        $pairs = [];
         foreach ($style as $name => $value) {
-            $result .= "$name: $value; ";
+            $pairs[] = "$name: $value;";
         }
 
-        // Return null if empty to avoid rendering the "style" attribute.
-        return $result === '' ? null : rtrim($result);
+        return implode(' ', $pairs);
     }
 
     /**

tests/Benchmark/HtmlBench.php

@@ -0,0 +1,85 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Yiisoft\Html\Tests\Benchmark;
+
+use PhpBench\Benchmark\Metadata\Annotations\BeforeMethods;
+use PhpBench\Benchmark\Metadata\Annotations\Iterations;
+use PhpBench\Benchmark\Metadata\Annotations\Revs;
+use Yiisoft\Html\Html;
+
+/**
+ * @BeforeMethods({"setUp"})
+ */
+class HtmlBench
+{
+    private array $attributes;
+    private string $content;
+
+    public function setUp(): void
+    {
+        $this->attributes = [
+            'id' => 'test-id',
+            'class' => 'test-class another-class',
+            'data-test' => 'value',
+            'aria-label' => 'Test Label',
+            'style' => 'color: red; background: blue;',
+        ];
+        $this->content = 'Test content with <special> characters & symbols';
+    }
+
+    /**
+     * @Revs(1000)
+     * @Iterations(10)
+     */
+    public function benchDivCreation(): void
+    {
+        Html::div($this->content, $this->attributes)->render();
+    }
+
+    /**
+     * @Revs(1000)
+     * @Iterations(10)
+     */
+    public function benchFormCreation(): void
+    {
+        Html::form('/submit', 'POST', $this->attributes)->render();
+    }
+
+    /**
+     * @Revs(1000)
+     * @Iterations(10)
+     */
+    public function benchInputCreation(): void
+    {
+        Html::input('text', 'test_field', 'test_value', $this->attributes)->render();
+    }
+
+    /**
+     * @Revs(1000)
+     * @Iterations(10)
+     */
+    public function benchAttributeRendering(): void
+    {
+        Html::renderTagAttributes($this->attributes);
+    }
+
+    /**
+     * @Revs(1000)
+     * @Iterations(10)
+     */
+    public function benchEncoding(): void
+    {
+        Html::encode($this->content);
+    }
+
+    /**
+     * @Revs(1000)
+     * @Iterations(10)
+     */
+    public function benchAttributeEncoding(): void
+    {
+        Html::encodeAttribute($this->content);
+    }
+}