Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more constants and shorcut methods #65

Merged
merged 9 commits into from
Sep 2, 2024
Merged

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?

@arogachev arogachev requested a review from a team August 29, 2024 09:54
@arogachev arogachev self-assigned this Aug 29, 2024
@arogachev arogachev added type:task Task status:code review The pull request needs review. labels Aug 29, 2024
@arogachev arogachev added this to the 1.2 milestone Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.82%. Comparing base (5b9f1e4) to head (e4f97de).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
+ Coverage     96.63%   96.82%   +0.18%     
- Complexity       51       54       +3     
============================================
  Files             3        3              
  Lines           119      126       +7     
============================================
+ Hits            115      122       +7     
  Misses            4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog

src/IpHelper.php Outdated Show resolved Hide resolved
src/IpRanges.php Outdated Show resolved Hide resolved
@arogachev arogachev changed the title Add more constants Add more constants and shorcut methods Aug 29, 2024
@arogachev arogachev requested review from a team and vjik August 29, 2024 15:29
CHANGELOG.md Outdated Show resolved Hide resolved
src/IpHelper.php Outdated Show resolved Hide resolved
src/IpHelper.php Outdated Show resolved Hide resolved
src/IpHelper.php Outdated Show resolved Hide resolved
arogachev and others added 4 commits September 2, 2024 18:44
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@arogachev arogachev requested review from a team and vjik September 2, 2024 13:49
@arogachev arogachev merged commit 1c96ab0 into master Sep 2, 2024
27 checks passed
@arogachev arogachev deleted the add-more-constants branch September 2, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review. type:task Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants