Message publishing optimization #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
viktorprogger
commented
Apr 27, 2023
viktorprogger
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
| Fixed issues | #58 |
viktorprogger
added
the
status:under development
PR Summary
|
vjik
reviewed
Apr 28, 2023
|
Tests? |
…g-optimization # Conflicts: # tests/Unit/QueueTest.php
s1lver
requested changes
Jun 15, 2023
| $this->message = new AMQPMessage('', $this->queueProvider->getMessageProperties()); | ||
| } | ||
|
|
||
| return $this->message; |
There was a problem hiding this comment.
Scrutinizer review
The expression return $this->message could return the type null which is incompatible with the type-hinted return PhpAmqpLib\Message\AMQPMessage. Consider adding an additional type-check to rule them out.
…g-optimization # Conflicts: # tests/Unit/QueueTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.