Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #101: Rename UserAuth to WebAuth, mark UserAuth as deprecated, add ApiAuth authentication method #105

Merged
merged 12 commits into from
Nov 11, 2024

Conversation

olegbaturin
Copy link
Contributor

@olegbaturin olegbaturin commented Oct 23, 2024

rename UserAuth to WebAuth
add ApiAuth

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️/❌ has deprecated class

#101

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (8995f02) to head (d06cae5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #105      +/-   ##
============================================
+ Coverage     99.62%   99.65%   +0.03%     
- Complexity       99      108       +9     
============================================
  Files            13       15       +2     
  Lines           270      294      +24     
============================================
+ Hits            269      293      +24     
  Misses            1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config/di-web.php Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@vjik vjik requested a review from a team October 24, 2024 08:20
@vjik vjik added the status:code review The pull request needs review. label Oct 24, 2024
tests/WebAuthTest.php Outdated Show resolved Hide resolved
@vjik vjik requested a review from a team October 24, 2024 10:06
README.md Outdated Show resolved Hide resolved
src/Method/ApiAuth.php Outdated Show resolved Hide resolved
src/Method/WebAuth.php Outdated Show resolved Hide resolved
src/UserAuth.php Outdated Show resolved Hide resolved
tests/ApiAuthTest.php Outdated Show resolved Hide resolved
tests/ApiAuthTest.php Outdated Show resolved Hide resolved
tests/ApiAuthTest.php Outdated Show resolved Hide resolved
@olegbaturin olegbaturin requested a review from samdark October 28, 2024 07:56
@olegbaturin olegbaturin requested a review from samdark November 9, 2024 07:51
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@samdark samdark changed the title rename UserAuth to WebAuth Fix #101: Rename UserAuth to WebAuth, mark UserAuth as deprecated, add ApiAuth authentication method Nov 11, 2024
@samdark samdark merged commit ea46dc6 into yiisoft:master Nov 11, 2024
18 checks passed
@samdark
Copy link
Member

samdark commented Nov 11, 2024

Thank you!

@olegbaturin olegbaturin deleted the 101-user-auth-methods branch November 24, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants