Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StringValue rule #595

Merged
merged 12 commits into from
Mar 16, 2023
Merged

Add StringValue rule #595

merged 12 commits into from
Mar 16, 2023

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues #594

@arogachev arogachev self-assigned this Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (0ee5e82) 94.69% compared to head (899c98e) 94.79%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #595      +/-   ##
============================================
+ Coverage     94.69%   94.79%   +0.10%     
- Complexity      727      735       +8     
============================================
  Files            85       86       +1     
  Lines          2204     2229      +25     
============================================
+ Hits           2087     2113      +26     
+ Misses          117      116       -1
Impacted Files Coverage Δ
src/Rule/Length.php 81.81% <ø> (ø)
src/Rule/StringValue.php 100.00% <100.00%> (ø)
src/Rule/StringValueHandler.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arogachev arogachev linked an issue Mar 15, 2023 that may be closed by this pull request
Missing StringValue rule #594
Closed
@arogachev arogachev requested a review from a team March 15, 2023 07:12
@arogachev arogachev added the type:enhancement Enhancement label Mar 15, 2023
@arogachev arogachev marked this pull request as ready for review March 15, 2023 07:12
vjik
vjik requested changes Mar 15, 2023
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good. Several improvements are required:

  • line in changelog
  • kill mutants

@arogachev arogachev requested review from vjik and a team March 15, 2023 11:41
@vjik vjik merged commit b0044e0 into master Mar 16, 2023
@vjik vjik deleted the 594-string-value branch March 16, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

Assignees

@arogachev arogachev

Labels
type:enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing StringValue rule
4 participants
@arogachev @samdark @vjik @StyleCIBot