Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of $escape argument in Error::getValuePath() from bool|string|null to string|null #702

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

…Path()` from `bool|string|null` to `string|null`""

This reverts commit c5a2b49.
@arogachev arogachev changed the base branch from 1.x to master April 12, 2024 09:58
@arogachev arogachev requested a review from a team April 12, 2024 09:59
@arogachev arogachev self-assigned this Apr 12, 2024
@arogachev arogachev added the type:task Task label Apr 12, 2024
@arogachev arogachev linked an issue Apr 12, 2024 that may be closed by this pull request
@arogachev arogachev added this to the 2.0 milestone Apr 12, 2024
@arogachev arogachev added the status:code review The pull request needs review. label Apr 12, 2024
@vjik vjik merged commit 62dae1c into master Apr 13, 2024
24 of 25 checks passed
@vjik vjik deleted the 613-remove-bool-escape branch April 13, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review. type:task Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove boolean support in Error::getValuePath()
2 participants