Skip to content

Expand test coverage for renderer type validation to include non-object types #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: 289-double-extensions
Choose a base branch
from
+56 −0
Draft

Expand test coverage for renderer type validation to include non-object types #297

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d48d126
Initial plan
Copilot Jan 15, 2026
7721c41
Add test cases for non-object renderer types (null, string, array, int)
Copilot Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions tests/ViewTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,62 @@ public function testWithRenderersInvalidRendererTypeThrowsException(): void
]);
}

public function testWithRenderersNullRendererThrowsException(): void
{
$view = TestHelper::createView();

$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage(
'Renderer null is not an instance of ' . TemplateRendererInterface::class . '.'
);

$view->withRenderers([
'php' => null,
]);
}

public function testWithRenderersStringRendererThrowsException(): void
{
$view = TestHelper::createView();

$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage(
'Renderer string is not an instance of ' . TemplateRendererInterface::class . '.'
);

$view->withRenderers([
'php' => 'invalid-renderer',
]);
}

public function testWithRenderersArrayRendererThrowsException(): void
{
$view = TestHelper::createView();

$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage(
'Renderer array is not an instance of ' . TemplateRendererInterface::class . '.'
);

$view->withRenderers([
'php' => [],
]);
}

public function testWithRenderersIntegerRendererThrowsException(): void
{
$view = TestHelper::createView();

$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage(
'Renderer int is not an instance of ' . TemplateRendererInterface::class . '.'
);

$view->withRenderers([
'php' => 123,
]);
}

public function testWithRenderersNumericKeyImplicitThrowsException(): void
{
$view = TestHelper::createView();
Expand Down
Loading