Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated composer depedencies to be the same as the advanced application #262

Merged
merged 31 commits into from
Jun 17, 2022
Merged

Updated composer depedencies to be the same as the advanced application #262

merged 31 commits into from
Jun 17, 2022

Conversation

developedsoftware
Copy link
Contributor

@developedsoftware developedsoftware commented Jun 6, 2022

Q A
Is bugfix? no
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues comma-separated list of tickets # fixed by the PR, if any

Closes #263

@developedsoftware developedsoftware changed the title Updated composer depedencies to work with Codeception 5 Updated composer depedencies to be the same as the advanced application Jun 6, 2022
@developedsoftware
Copy link
Contributor Author

developedsoftware commented Jun 6, 2022

Hmm not sure if this is an issue with GitHub CI but I am getting references to swiftmailer even though in test.php I have and tests pass locally...

'mailer' => [
            'class' => 'yii\symfonymailer\Mailer',
            // send all mails to a file by default. You have to set
            // 'useFileTransport' to false and configure transport
            // for the mailer to send real emails.
            'useFileTransport' => true,
        ],

@developedsoftware
Copy link
Contributor Author

Not sure how I can get this work so will have to park it for now. I have no reference to swiftmailer in the code so it must be pulling in that code from somewhere else as part of the CI @samdark

@developedsoftware
Copy link
Contributor Author

Will require #264 to be merged in before checks will pass.

@samdark samdark merged commit 9d3b845 into yiisoft:master Jun 17, 2022
@samdark
Copy link
Member

samdark commented Jun 17, 2022

Thanks!

@samdark samdark added this to the 2.0.46 milestone Jun 17, 2022
@WinterSilence WinterSilence mentioned this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should this be in sync with the advanced template?
2 participants