Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar lack of personalization #111

Open
yii-bot opened this issue Jan 24, 2016 · 1 comment
Open

Navbar lack of personalization #111

yii-bot opened this issue Jan 24, 2016 · 1 comment
Labels
status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement

Comments

@yii-bot
Copy link

yii-bot commented Jan 24, 2016

This issue has originally been reported by @invaderhd at yiisoft/yii2#7499.
Moved here by @cebe.


In a project I use Navbar extensively and I found that it should be more generic, for example:

  • we should be able to set the the only the classes that we want to use, but it append allwais the navbar class (ie. Html::addCssClass($this->options, 'navbar'); )
  • it's impossible to remove the toggle button (ie. echo $this->renderToggleButton();). In some layouts we may have the toggle button in a different local.

The Navbar is a great class and works like a charm in the default bootstrap theme, but in custom layouts it is not generic enough to do it job.

Keep the good working guys ;)

@klimov-paul
Copy link
Member

we should be able to set the the only the classes that we want to use, but it append allwais the navbar class (ie. Html::addCssClass($this->options, 'navbar'); )

This is already possible:

'options' => [
    'class' => ['widget' => null],
],

it's impossible to remove the toggle button (ie. echo $this->renderToggleButton();). In some layouts we may have the toggle button in a different local.

This can be considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants