Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar lack of personalization #7499

Closed
fabiomlferreira opened this issue Feb 28, 2015 · 3 comments
Closed

Navbar lack of personalization #7499

fabiomlferreira opened this issue Feb 28, 2015 · 3 comments

Comments

@fabiomlferreira
Copy link

In a project I use Navbar extensively and I found that it should be more generic, for example:

  • we should be able to set the the only the classes that we want to use, but it append allwais the navbar class (ie. Html::addCssClass($this->options, 'navbar'); )
  • it's impossible to remove the toggle button (ie. echo $this->renderToggleButton();). In some layouts we may have the toggle button in a different local.

The Navbar is a great class and works like a charm in the default bootstrap theme, but in custom layouts it is not generic enough to do it job.

Keep the good working guys ;)

@creocoder
Copy link
Contributor

@invaderhd

but in custom layouts it is not generic enough to do it job

With correct bootstrap customizing you'll always have class="navbar ..." start. If you feel you do not need navbar class this is incorrect way of extending bootstrap. There is classes like navbar-default and navbar-inverse. If you need some different navbar, just create new class navbar-project.

In some layouts we may have the toggle button in a different local.

For toggle button example needed.

@patlecat
Copy link

@invaderhd You are right, the Yii-components are usually rigid and cannot be easily customized, sometimes because of lack of documentation and sometimes because it's not possible. I wanted to add an icon instead of text but not possible. There is someone working on this though now. Don't know when the rest will be reworked or rather completed.

@yii-bot
Copy link

yii-bot commented Jan 24, 2016

Issue moved to yiisoft/yii2-bootstrap#111

@yii-bot yii-bot closed this as completed Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants