Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise min PHP version to PHP 7.3, check compatibility PHP 8.3. #278

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Oct 4, 2023

PR Summary

  • Updated Configuration for .yml Files
    The .editorconfig has been adjusted to require a 2-space indent size for .yml files, enhancing code readability.

  • Link for Feedback / Design Discussion Updated
    The documentation now directs contributors to the updated link for providing feedback or initiating design conversations.

  • Updated Package in Funding Info
    The Tidelift package for yii2-bootstrap has been updated to packagist/yiisoft/yii2-bootstrap5 in .github/FUNDING.yml.

  • Improved Clarity in Issue Templates
    The phrase "What's expected?" has been clarified to "What is the expected result?" in issue reporting template to facilitate better user communication.

  • Updated PHP Versions for Unit Tests
    The platform versions for running unit tests have been updated in .github/workflows/build.yml.

  • More Stringent PHP and PHPUnit Version Requirements
    The composer.json now requires a higher PHP version (>=7.3), and a specific PHPUnit version (^9.6).

  • Included src Directory in Code Coverage
    The src directory is now included in the code coverage configuration in phpunit.xml.dist.

  • Tests Methods Return Types & Assertions Updated
    Various setUp methods across test files now use void return types for robustness. Moreover, assertions have been updated to assertStringContainsString and assertStringNotContainsString methods in ActiveFieldTest.php for improved test accuracy.

  • Updated Exception Handling
    The testMissingLabel method in CollapseTest.php now expects an InvalidConfigException, enhancing error handling.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant