Allow override CSS classes added by widgets #52
Conversation
|
Tests are currently failing on Travis, because it uses old version of 'yiisoft/yii2' |
| @@ -18,7 +18,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "yiisoft/yii2": ">=2.0.4", | |||
| "yiisoft/yii2": "*", | |||
There was a problem hiding this comment.
this must keep >=2.0.4 because it depends on the security issue fix in Json helper.
There was a problem hiding this comment.
It need to be a master branch, because it depends on changes made recently.
What whould be correct value then?
During 2.0.5 release it should be set to ">=2.0.5", but what value should be used until then?
There was a problem hiding this comment.
I think it is good to require >2.0.4 to indicate dev dependency for something after 2.0.4
There was a problem hiding this comment.
not sure if composer can resolve this though...
|
looks good to me, except the version constraint in composer.json |
|
Build solved using |
|
👍 |
|
@klimov-paul shouldn't it be |
|
I am afraid it should not. For '2.0.x-dev' there is an alias declared at yii2 composer.json: Either way it should be changed to ">=2.0.5" before next release. |
|
OK. |
Allow override CSS classes added by widgets
Fixes:
#15
yiisoft/yii2#8229
yiisoft/yii2#8257
yiisoft/yii2#8405
yiisoft/yii2#4916