Fix #243: Checkbox labels in inline forms are no longer hidden

yiisoft · Apr 17, 2024 · e8a24f2 · e8a24f2
1 parent f9a55eb
commit e8a24f2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ Yii Framework 2 bootstrap4 extension Change Log
 ------------------------
 
 - Enh #237: Added `Accordion::headerToggleOptions` (nagyt234)
+- Bug #243: Checkbox labels in inline forms are no longer hidden (BBoom)
 
 2.0.11 May 22, 2023
 -------------------

diff --git a/src/ActiveField.php b/src/ActiveField.php
@@ -269,6 +269,9 @@ public function checkbox($options = [], $enclosedByLabel = false)
  Html::removeCssClass($this->labelOptions, $this->horizontalCssClasses['label']);
  Html::addCssClass($this->wrapperOptions, $this->horizontalCssClasses['offset']);
  }
+ if ($this->form->layout === ActiveForm::LAYOUT_INLINE) {
+ Html::removeCssClass($this->labelOptions, 'sr-only');
+ }
  unset($options['template']);
 
  if ($enclosedByLabel) {

diff --git a/tests/ActiveFormTest.php b/tests/ActiveFormTest.php
@@ -194,7 +194,7 @@ public function testInlineLayout()
 <div class="form-group field-dynamicmodel-checkboxname">
 <div class="custom-control custom-checkbox">
 <input type="hidden" name="DynamicModel[checkboxName]" value="0"><input type="checkbox" id="dynamicmodel-checkboxname" class="custom-control-input" name="DynamicModel[checkboxName]" value="1">
-<label class="sr-only custom-control-label" for="dynamicmodel-checkboxname">Checkbox Name</label>
+<label class="custom-control-label" for="dynamicmodel-checkboxname">Checkbox Name</label>
 
 
 </div>