Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion::headerToggleOptions and Modal::titleOptions[tag] implemented #237

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

nagyt234
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #225

@what-the-diff
Copy link

what-the-diff bot commented Sep 21, 2023

PR Summary

  • Enhancement of the Accordion Class
    The Accordion class now has a new property: $headerToggleOptions. This allows for the customization of HTML options for the header toggle tag, providing more flexibility for users. The default options are a 'h5' tag and a 'mb-0' class.

  • Update to the renderItem Method
    We've updated how the renderItem method in Accordion class works. It now uses the $headerToggleOptions property to create the header toggle tag in every item. This means each part of the list can have its own unique look and feel, further improving the class's flexibility.

  • Testing of New Property and Functionality
    A new test, testHeaderToggleTag, has been added to ensure that the $headerToggleOptions property and the updated renderItem method are working as expected. This provides added assurance that these additions to the class are tested and validated, ensuring smooth, reliable performance for users.

@bizley
Copy link
Member

bizley commented Sep 22, 2023

Please add a changelog line, thanks.

@nagyt234
Copy link
Contributor Author

Please add a changelog line, thanks.

I did.

@nagyt234 nagyt234 changed the title Accordion::headerToggleOptions implemented Accordion::headerToggleOptions and Modal::titleOptions[tag] implemented Sep 25, 2023
@bizley bizley merged commit 98adfa6 into yiisoft:master Sep 26, 2023
9 checks passed
@bizley bizley added this to the 2.0.12 milestone Sep 26, 2023
@bizley bizley added the type:enhancement Enhancement label Sep 26, 2023
@bizley
Copy link
Member

bizley commented Sep 26, 2023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants