Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise min version to PHP 7.3, check compatibility PHP 8.3. #238

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 26, 2023

PR Summary

  • Updated GitHub Actions in build.yml
    Updated to the latest versions of GitHub Actions in our workflow to ensure smooth, efficient and secure operation.
  • Upgraded PHPUnit Package
    The package phpunit/phpunit used for testing has been upgraded to the latest version (^9.6) improving the accuracy and reliability of our unit tests.
  • Adjusted Exception Expectations in Tests
    Tests in AccordionTest.php have been updated to expect an InvalidConfigException, ensuring our testing setup aligns with the expected software behaviors.
  • Code Formatting and Setup Method Updates in Several Test Files
    Minor code formatting adjustments and an update to the setUp method in several test files for maintaining a consistent style and performance.
  • Updated Test Output Expectations
    Tests in ButtonDropdownTest.php, and CarouselTest.php, were updated to expect specific output, confirming our components deliver the expected HTML output.
  • Method and Class Renames in Test Files
    To increase readability and clarity, several methods and a test class have been renamed in ToggleButtonGroupTest.php.
  • Removed Redundant File and Checks
    The compatibility.php file and certain class checks in mentioned file, have been removed from the tests folder, helping to streamline our codebase.

Note: This PR mostly includes maintenance updates improving the efficiency, reliability, and readability of our test suite and build process.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@mtangoo
Copy link

mtangoo commented Feb 15, 2024

Shouldn't this go up to at least 7.4 for the version before raising to 8.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants