Add "fools protection" in BootstrapWidgetTrait

[WinterSilence]

Q	A
Is bugfix?	✔️/❌
New feature?	❌
Breaks BC?	❌
Fixed issues	#49

[simialbi]

Doesn't this make debugging more complicated? If the element is not present, you don't see an exception in browser console any more with this change.

[WinterSilence]

@simialbi I expressed my opinion in #49, but I think that he is not alone... I don't planed break popular extensions :)

[simialbi]

Ok. So kartik's gridview uses the widget without rendering the button? Maybe there is a better solution which does not break debug option 🤔.

[WinterSilence]

@simialbi his widget using template like as $template = "{head}{body}{footer}"; and renders blocks for all placeholders, but user can customize template and remove some placeholders: $template = "{head}{body}"; in this case {footer} block still rendered. Footer output BS widget and widget add self JS to page.

[WinterSilence]

@simialbi my solution is use preg_replace_callback('/{\w+}/', $callback, $template) instead strtr($template, ['head' => $this->renderHead(), ...]), but I don't plan to seminars "How optimize your code" for authors of popular extensions (:

[kartik-v]

Doesn't this make debugging more complicated? If the element is not present, you don't see an exception in browser console any more with this change.

This is a breaking change from v2.0.3. When using earlier with jQuery in yii2-bootstrap5 v2.0.3 - no debug/error message was thrown even if the selector $id does not exist because of the way jQuery inherently works and been designed.

"jQuery('#$id').$name($options);"  // will not throw any console error even if selector with $id does not exist

I assume the same behavior should be implemented for use without jQuery - else its a BC Breaking change from 2.0.3 to 2.0.4.

var bs5pluginElement = document.getElementById('$id'); 
// this will throw an error when bs5pluginElement is used in subsequent javascript operations
// without validating if it is undefined

IMO... individual developers should choose to validate if needed for their use case, whether the element exists or not before initializing the plugin or bootstrap widget and the widget should be allowed to render like earlier without any errors - or this could be a configuration option for the widget/plugin.

[kartik-v]

@simialbi my solution is use preg_replace_callback('/{\w+}/', $callback, $template) instead strtr($template, ['head' => $this->renderHead(), ...]), but I don't plan to seminars "How optimize your code" for authors of popular extensions (:

You are free to suggest any improvement to any extension code (if you want to) as its a OPEN SOURCE community where you can raise enhancement suggestions - just like you have raised a PR here. Have given few of my feedback for this PR as well. Thanks.

[newadventure079]

@WinterSilence Did you misspell lenght?

Also, bs5pluginElement.length > 0 will fail with Cannot read properties of null (reading 'length'). I changed it locally to bs5pluginElement != null && bs5pluginElement.length > 0