Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default access control for controller methods #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshijitendra
Copy link

Q A
Is bugfix? no
New feature? yes
Breaks BC? no

@samdark
Copy link
Member

samdark commented Dec 19, 2016

Does not make sense to me. Would you please explain why the change is required?

@samdark samdark closed this Dec 19, 2016
@cebe cebe added the type:enhancement Enhancement label Dec 19, 2016
@joshijitendra
Copy link
Author

This adds getting started code for access control filter which can improved further as required and saves time for having to add it manually for CRUD generator. Also it is in line with yii1 gii which has similar behaviour to add a default access control filter.

I am open to any better implementation/suggestion.

@cebe
Copy link
Member

cebe commented Dec 19, 2016

I am for adding this because nearly all crud needs some access control and this way it is less likely to be forgotten. It could be configurable somehow. not sure how though.

@cebe cebe reopened this Dec 19, 2016
@samdark
Copy link
Member

samdark commented Dec 25, 2016

Thinking about it once again, it should be OK.

@samdark samdark self-assigned this Dec 25, 2016
@Sensetivity
Copy link

Maybe make sense do this feature optional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants