Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update composer.json #364

Merged
merged 2 commits into from
May 22, 2018
Merged

Update composer.json #364

merged 2 commits into from
May 22, 2018

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix? yes/no
New feature? yes/no
Breaks BC? yes/no
Tests pass? yes/no
Fixed issues comma-separated list of tickets # fixed by the PR, if any

@schmunk42 schmunk42 self-requested a review May 22, 2018 08:57
schmunk42
schmunk42 requested changes May 22, 2018
View reviewed changes
Copy link
Contributor

@schmunk42 schmunk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need to be put into a config section, see https://github.com/dmstr/phd5-app/blob/master/composer.json#L22-L33 for an example.

@rustamwin
Copy link
Member Author

@schmunk42 fixed thanks!

@samdark samdark merged commit c544316 into yiisoft:master May 22, 2018
@samdark
Copy link
Member

samdark commented May 22, 2018

Merged. Thanks!

@samdark samdark added this to the 2.0.8 milestone May 22, 2018
@rustamwin rustamwin deleted the patch-1 branch May 22, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmunk42 schmunk42 schmunk42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@rustamwin @samdark @schmunk42