-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use model attributes instead of schema in CRUD generator #470
base: master
Are you sure you want to change the base?
Conversation
WinterSilence
commented
Sep 25, 2021
Q | A |
---|---|
Is bugfix? | yes |
New feature? | no |
Breaks BC? | no |
Tests pass? | yes |
Fixed issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea !
Would you please post an example output in comment ?
@samdark shouldn't we have tests in this extension, including & comparing outputs ? That would make it easier to track changes |
@machour yeah but we don't have any :) |
Maybe we should start with adding these, and only then start refactoring this extension. Right now reviewing such PRs is a nightmare - it is often really hard to understand what are the actual implications of some changes. |