Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise min PHP version to PHP 7.3, check compatibility PHP 8.3. #140

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Oct 4, 2023

PR Summary

  • Editor Configuration Adjustment
    The .editorconfig file has been updated to set an indent size of 2 for .yml files. This helps to maintain a consistent code style across different editors and IDEs.

  • Workflow Optimization
    The "build" workflow has been improved to only activate on push and pull request events; it also now ignores certain files that do not affect the overall functionality. This change refines our build process and focuses on relevant files.

  • PHP Version Update
    The PHP version requirement in composer.json has been increased to 7.3 or higher to ensure compatibility with the latest features.

  • PHPUnit Package Update
    The version of the PHPUnit package in our composer.json file has been upgraded to 9.6 or higher. This will grant us access to the most recent PHPUnit testing features.

  • PHPUnit Configuration Changes
    Considerable modifications were made to phpunit.xml.dist to update the XML structure and add a coverage section. Coverage enables comprehensive testing and helps track the percentage of our code covered by these tests.

  • Test Case Modifications
    The design methods have been refined in various test cases, particularly the TestCase.php and ViewRendererTest.php files. Notably, the setUp and terminate methods now explicitly declare return type as void. This ensures that these methods do not need to return a value.

  • Assertion Updates in Tests
    In the ViewRendererTest.php file, several assertions have been updated to use new assertStringContainsString and assertStringNotContainsString methods. This move streamlines our testing process and provides more precise assertion results.

  • Removal of Redundant File
    The compatibility.php file in the tests directory has been removed as it was no longer needed, decluttering our workspace for better efficiency.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@eliecerjr-tech
Copy link

@terabytesoftw Is this something that is being worked on ? I am currently working on upgrading a Yii2 app with Twig to PHP@8.2 and this will help a lot :)

@terabytesoftw
Copy link
Member Author

We are waiting for PHP 8.3 to come out, all the Framework updates and all the packages are ready.

@schmunk42
Copy link
Contributor

@terabytesoftw PHP 8.3 was released btw ;)

@terabytesoftw terabytesoftw marked this pull request as ready for review May 17, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants