Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bootstrap to 3.1.1 #3036

Closed
2 tasks done
samdark opened this issue Apr 9, 2014 · 18 comments
Closed
2 tasks done

Upgrade bootstrap to 3.1.1 #3036

samdark opened this issue Apr 9, 2014 · 18 comments
Assignees
Milestone

Comments

@samdark
Copy link
Member

samdark commented Apr 9, 2014

  • Update dependency
  • Adjust code if needed (check release notes)
@samdark samdark added this to the 2.0 RC milestone Apr 9, 2014
@artemzakholodilo
Copy link

I can update my bootstrap version by composer?

@samdark
Copy link
Member Author

samdark commented Apr 9, 2014

Yes but we can't guarantee that markup generated for 3.0 is compatible with 3.1.

@artemzakholodilo
Copy link

I can work with 3.1.1 in new project?

@samdark
Copy link
Member Author

samdark commented Apr 9, 2014

You can try it but it will be "yes" when this task will be finished.

@cebe
Copy link
Member

cebe commented Apr 9, 2014

upgrade should go same way as jquery to have default 3.1.* but allows 3.0

@samdark
Copy link
Member Author

samdark commented Apr 9, 2014

@cebe I'm not sure about it. We're generating bootstrap markup so if 3.1 differs from 3.0 our PHP helpers will generate wrong markup for 3.1 after updating these.

@cebe
Copy link
Member

cebe commented Apr 9, 2014

helpers are configurable so one can choose the bootstrap version as he needs. For example I have bootstrap fixed at 3.0.3 in one project because they break my layout in higher version.

@bryglen
Copy link

bryglen commented Apr 9, 2014

We are still not in production. So i suggest we should use latest bootstrap

@cebe
Copy link
Member

cebe commented Apr 9, 2014

@bryglen the default will be the latest version.

@Sammaye
Copy link

Sammaye commented Apr 14, 2014

I believe bootstrap uses semver: http://semver.org/ which means that minor versions should be backwards compatible ( https://github.com/twbs/bootstrap/#versioning ) so it should be fine to upgrade 3.1 without worrying about breakages

@lordlele
Copy link

Uhm, 3.1 break BC for modal with remote option as you can see here:

twbs/bootstrap#11933

@cebe cebe modified the milestone: 2.0 RC Apr 14, 2014
@Sammaye
Copy link

Sammaye commented Apr 14, 2014

So much for conforming to the versioning standards they created :\

@lordlele
Copy link

As you can see from their README:

For transparency into our release cycle and in striving to maintain backward compatibility, Bootstrap is maintained under the Semantic Versioning guidelines. Sometimes we screw up, but we'll adhere to these rules whenever possible.

screw up happens 😃

@Sammaye
Copy link

Sammaye commented Apr 14, 2014

IMO even though that's been added it's not really an excuse, if there is a
breaking change you need to tell people by all means including versioning.

Anyway, okay.

On 14 April 2014 09:42, Emanuele Deserti notifications@github.com wrote:

As you can see from their README:

For transparency into our release cycle and in striving to maintain
backward compatibility, Bootstrap is maintained under the Semantic
Versioning guidelines. Sometimes we screw up, but we'll adhere to these
rules whenever possible.

screw up happens [image: 😃]

Reply to this email directly or view it on GitHubhttps://github.com//issues/3036#issuecomment-40344359
.

@lordlele
Copy link

I agree completely with you

@robregonm
Copy link
Contributor

After testing the yii2-widgets, there are no noticeable breaks when using bootstrap version 3.1.1. (Even in some cases the UI get some minor improvements)

@kartik-v
Copy link
Contributor

I have set the Krajee Demos site to use bootstrap v3.1.1 CSS and JS (via Yii Asset Manager) and also use JQuery 2.1.0. Can be used as an important testing playground for validating this (no problems faced so far).

With regards BS3.1.1, there are various minor improvements - for example better inline form alignment. Compare this to checkbox alignment in earlier version.

@samdark samdark self-assigned this Apr 22, 2014
@qiangxue
Copy link
Member

Thank you all for testing. I updated the composer.json to 3.1.x.
Let's create new issues if we find there is anything wrong in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants