-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bootstrap to 3.1.1 #3036
Comments
I can update my bootstrap version by composer? |
Yes but we can't guarantee that markup generated for 3.0 is compatible with 3.1. |
I can work with 3.1.1 in new project? |
You can try it but it will be "yes" when this task will be finished. |
upgrade should go same way as jquery to have default 3.1.* but allows 3.0 |
@cebe I'm not sure about it. We're generating bootstrap markup so if 3.1 differs from 3.0 our PHP helpers will generate wrong markup for 3.1 after updating these. |
helpers are configurable so one can choose the bootstrap version as he needs. For example I have bootstrap fixed at 3.0.3 in one project because they break my layout in higher version. |
We are still not in production. So i suggest we should use latest bootstrap |
@bryglen the default will be the latest version. |
I believe bootstrap uses semver: http://semver.org/ which means that minor versions should be backwards compatible ( https://github.com/twbs/bootstrap/#versioning ) so it should be fine to upgrade 3.1 without worrying about breakages |
Uhm, 3.1 break BC for modal with remote option as you can see here: |
So much for conforming to the versioning standards they created :\ |
As you can see from their README:
screw up happens 😃 |
IMO even though that's been added it's not really an excuse, if there is a Anyway, okay. On 14 April 2014 09:42, Emanuele Deserti notifications@github.com wrote:
|
I agree completely with you |
After testing the yii2-widgets, there are no noticeable breaks when using bootstrap version 3.1.1. (Even in some cases the UI get some minor improvements) |
I have set the Krajee Demos site to use bootstrap v3.1.1 CSS and JS (via Yii Asset Manager) and also use JQuery 2.1.0. Can be used as an important testing playground for validating this (no problems faced so far). With regards BS3.1.1, there are various minor improvements - for example better inline form alignment. Compare this to checkbox alignment in earlier version. |
Thank you all for testing. I updated the composer.json to 3.1.x. |
The text was updated successfully, but these errors were encountered: