-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load MySQL comments into TableSchema #13162
Conversation
michaelarnauts
commented
Dec 8, 2016
•
edited by samdark
Loading
edited by samdark
Q | A |
---|---|
Is bugfix? | yes/no |
New feature? | yes |
Breaks BC? | no |
Tests pass? | yes |
Fixed issues | #13154 (partially) |
framework/db/TableSchema.php
Outdated
@@ -35,6 +35,10 @@ class TableSchema extends Object | |||
*/ | |||
public $fullName; | |||
/** | |||
* @var string the comment that has been assigned to this table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need @since 2.0.12
.
framework/db/mysql/Schema.php
Outdated
@@ -122,6 +123,27 @@ protected function resolveTableNames($table, $name) | |||
} | |||
|
|||
/** | |||
* Loads the table comment into the [[TableSchema]] object. | |||
* @param TableSchema $table the table metadata object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need @since 2.0.12
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about other database engines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have a MySQL server
I've added the |
Great. We can't really release it for MySQL only so will see if we'll have enough time to implement all other DB engines support before 2.0.12... |
I'm not sure about other databases. |
SQLite seems not to support comments at all. |
Thank you for putting effort in the improvement of the Yii framework. In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests. Could you add these please? Thanks! P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests This is an automated comment, triggered by adding the label |
Won't make it into 2.0. |