Add InputWidget::createInputField()
#14441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdark
approved these changes
Jul 12, 2017
dynasource
suggested changes
Jul 12, 2017
framework/widgets/InputWidget.php
Outdated
| * @see Html::activeInput() | ||
| * @see Html::input() | ||
| */ | ||
| protected function createInputField($type) |
There was a problem hiding this comment.
isnt this ambigious as it renders a HTML tag and not actually creating a Field? Perhabs a better name is renderInput()
cebe
force-pushed
the
input-widget
branch
2 times, most recently
from
4ef72d5
to
23a850b
Compare
to implement behavior described in class docs directly in the class itself instead of relying on subclasses to respect the description. fixes yiisoft#14294
dynasource
approved these changes
Jul 13, 2017
|
Merged. Good one. |
|
Introducing In my projects this change affected at least three widgets: hiqdev/yii2-combo@af68b15 |
SilverFire
added
the
severity:BC breaking
|
Ooops ... @SilverFire can you open an issue? |
|
reopened #14294 (comment) |
SilverFire
added a commit
that referenced
this pull request
Jul 13, 2017
…vior described in `InputWidget` class docs to the class itself" This reverts commit a5b393a. See #14441 (comment) for reasons
qiangxue
pushed a commit
to yiisoft/yii2-framework
that referenced
this pull request
Jul 13, 2017
…vior described in `InputWidget` class docs to the class itself" This reverts commit a5b393a3c101bebeb0c60aac4e11d5a7c6dd8244. See yiisoft/yii2#14441 (comment) for reasons
hiqsol
pushed a commit
to yiisoft/cache
that referenced
this pull request
Jul 14, 2018
…vior described in `InputWidget` class docs to the class itself" This reverts commit a5b393a3c101bebeb0c60aac4e11d5a7c6dd8244. See yiisoft/yii2#14441 (comment) for reasons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to implement behavior described in class docs directly in the class
itself instead of relying on subclasses to respect the description.
fixes #14294