Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flags to ColumnSchema to disable JSON and Arrays support #15755

Closed
wants to merge 2 commits into from

Conversation

SilverFire
Copy link
Member

Fixes #15716

Don't want to write tests for this new deprecated feature 🙈

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is OK. Descriptions could be improved by omitting "temporary" from descriptions. Also deserialize → unserialize.

Copy link
Member

@sergeymakinen sergeymakinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (sigh)
Minor corrections are required as noted by @samdark.

@SilverFire
Copy link
Member Author

Fixed by 25d176a

@SilverFire SilverFire closed this Feb 24, 2018
@SilverFire SilverFire deleted the schema-bc-flag branch February 24, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants