Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade note for #18083 #18119

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Upgrade note for #18083 #18119

merged 1 commit into from
Jun 19, 2020

Conversation

brandonkelly
Copy link
Contributor

Adds a note to UPGRADE.md, to warn people that they should make sure their controllers’ init() methods are calling parent::init().

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Tests pass? ✔️

@brandonkelly brandonkelly mentioned this pull request Jun 18, 2020
Merged
@samdark samdark added this to the 2.0.36 milestone Jun 19, 2020
@samdark samdark merged commit a41879a into yiisoft:master Jun 19, 2020
@samdark
Copy link
Member

samdark commented Jun 19, 2020

👍

@samdark samdark mentioned this pull request Jun 19, 2020
Closed
@lubosdz
Copy link
Contributor

lubosdz commented Jul 15, 2020

This should be top-mentioned in the upgrade composer notes for 2.0.36.
After upgrading from 2.0.35 our sites started breaking down.
Took some time to find changes in BaseController, commit and then this note.
I bet I am not the only one ..

@brandonkelly brandonkelly deleted the upgrade-edit branch February 16, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.36
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonkelly @samdark @lubosdz